fix: Remove coingecko-api-v3 library and de-dupe fetching utils #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrossy
requested review from
tkporter,
paulbalaji,
Mo-Hussain,
yorhodes and
ltyu
as code owners
🦋 Changeset detectedLatest commit: 5386679 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jmrossy
commented
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4837 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 103 103
Lines 1515 1515
Branches 195 195
=======================================
Hits 1130 1130
Misses 364 364
Partials 21 21
|
Mo-Hussain
approved these changes
Nov 7, 2024
paulbalaji
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getCoingeckoTokenPricesfunction which is redundant withCoinGeckoTokenPriceGetterCoinGeckoTokenPriceGetterand remove need for Mock classRelated: #4787
See discussion here: https://discord.com/channels/935678348330434570/1304125818817220653
Drive-by changes
Backward compatibility
No
Testing
Rewrote unit tests and tested Storybook